-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent execution with incompatible yamllint configuration #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
added a commit
to alvistack/docker-centos
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-bamboo
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-dnsmasq
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-fisheye
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-gitlab-ee
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-devel
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-fedora
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-gitlab-ce
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-opensuse
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-httpd
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-mitmproxy
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-mariadb
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-almalinux
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-postfix
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-jira
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-rhel
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-php-fpm
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-postgres
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-debian
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-devel
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/docker-ubuntu
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-centos
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-ceph
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-kubernetes
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-fedora
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-rhel
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-opensuse
that referenced
this pull request
May 19, 2024
hswong3i
added a commit
to alvistack/vagrant-ubuntu
that referenced
this pull request
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has the potential of breaking linting for users that do have a custom
.yamllint
config file. Still, the error given should make the fix very easy as it will mention each option that needs to be changed and to which value, like below:This change ensures that when running
--fix
we do not end-up with a regression regarding number of yamllint rule violations. As mentioned inside the documentation, there are technical and compatibility reasons why we cannot make these few options configurable.Fixes: #3890
Fixes: #4118